Skip to content

Added new Directory Ml and implemented basic algos#400

Merged
Pradeepsingh61 merged 3 commits into
Pradeepsingh61:mainfrom
lck6055:machine_learning
Oct 4, 2025
Merged

Added new Directory Ml and implemented basic algos#400
Pradeepsingh61 merged 3 commits into
Pradeepsingh61:mainfrom
lck6055:machine_learning

Conversation

@lck6055
Copy link
Copy Markdown

@lck6055 lck6055 commented Oct 4, 2025

Changes: in Python Directory

  1. Added new directory called "machine_learning".
  2. Implemented Linear Regression and Gradient Descent.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2025

💎 Code Quality Check Results

⚠️ Insufficient Comments

These files have very few comments:

  • Python/machine_learning/linear_regression.py

Recommended: Add inline comments explaining the logic and key steps

📚 Quality Standards

To maintain high quality, every contribution should include:

  1. ✍️ Algorithm Description

    • Explain what the algorithm does
    • Describe the approach and methodology
    • Include use cases or applications
  2. 📊 Complexity Analysis

    • Time complexity (e.g., O(n log n))
    • Space complexity (e.g., O(n))
    • Brief explanation of why
  3. 💬 Meaningful Comments

    • Explain complex logic
    • Document function parameters
    • Add inline comments for clarity
  4. ✅ Test Cases/Examples

    • Demonstrate the code works
    • Show different input scenarios
    • Include edge cases

💡 Example Template

"""
Binary Search Algorithm

Description: Searches for a target value in a sorted array using divide-and-conquer

Time Complexity: O(log n) - halves search space each iteration
Space Complexity: O(1) - only uses constant extra space
"""

def binary_search(arr, target):
    # Initialize pointers
    left, right = 0, len(arr) - 1

    while left <= right:
        mid = (left + right) // 2

        # Check if target found
        if arr[mid] == target:
            return mid
        # Search right half
        elif arr[mid] < target:
            left = mid + 1
        # Search left half
        else:
            right = mid - 1

    return -1  # Not found

# Test cases
if __name__ == "__main__":
    test_arr = [1, 3, 5, 7, 9]
    print(binary_search(test_arr, 5))  # Output: 2
    print(binary_search(test_arr, 6))  # Output: -1

🔧 How to Fix

  1. Review each file mentioned above
  2. Add the missing documentation
  3. Push your changes
  4. The workflow will re-run automatically

💪 You've Got This!

These checks help maintain quality and make your contribution more valuable to learners. Thank you for taking the time to improve! 🙏


Quality over quantity - let's build something amazing together! 🌟

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2025

🎉 Welcome to Hacktoberfest 2025, @lck6055! 🎃

Thank you for your first contribution to our DSA repository! Here's what happens next:

🔍 Automatic Checks

  • Code Validation: Passed
  • 🧪 Compilation Tests: Passed

📋 Next Steps

🎯 Great job! Your code compiled successfully. Maintainers @Karanjot786 and @Pradeepsingh61 will review your PR soon.

🎁 What You Get

  • 🏆 Hacktoberfest Credit: This PR counts toward your 6 PR goal for exclusive T-shirt + Tree!
  • 🌟 Hall of Fame: You'll be featured in our contributors list
  • 📚 Learning: Code review feedback from experienced developers

💡 Tips for Success

  • Follow our Contributing Guidelines
  • Add comments explaining your algorithm
  • Include time/space complexity analysis
  • Test your code before submitting

Welcome to the community! 🚀

@github-actions github-actions Bot requested a review from Karanjot786 October 4, 2025 09:42
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2025

🤖 Automated PR Status

🔍 Code Validation

Passed - File naming and structure look good!

🧪 Compilation Tests

Passed - All code compiles successfully!

📋 Overall Status

🎉 Ready for Review - Your PR has passed all automated checks!
👥 Maintainers have been notified for review.


This comment was generated automatically. Checks will re-run when you push new commits.

@lck6055
Copy link
Copy Markdown
Author

lck6055 commented Oct 4, 2025

Hi @Pradeepsingh61 , i read the readme.md as per it , i created a new ml directory , due to adding new directory my pr validation is failing, could you please look into it?

@Pradeepsingh61
Copy link
Copy Markdown
Owner

Hi @Pradeepsingh61 , i read the readme.md as per it , i created a new ml directory , due to adding new directory my pr validation is failing, could you please look into it?

@lck6055 thank for this PR and yes we will update for now i merge your PR

@Pradeepsingh61 Pradeepsingh61 merged commit b4af693 into Pradeepsingh61:main Oct 4, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants